Change "bigint" to "integer" in Postgres schema grammar. #33
+2
−2
Conversation
Bigint has too big a range to be returned as an int in PHP. It is returned as a string, which can be confusing and lead to unexpected results. In addition, the range of integer is suitable for most cases: -2147483648 to +2147483647.
|
Looks like you need to update the unit tests. :) |
|
Done. Thanks for the heads up :) Edit: Seems like Travis is hanging. I just sent them an email to ask they look into the error. |
|
+1 |
taylorotwell
added a commit
that referenced
this issue
Dec 7, 2012
Change "bigint" to "integer" in Postgres schema grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Bigint has too big a range to be returned as an int in PHP. It is returned as a string, which can be confusing when expecting an int to be returned. In addition, the range of integer is suitable for most cases: -2147483648 to +2147483647.