Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "bigint" to "integer" in Postgres schema grammar. #33

Merged
merged 4 commits into from Dec 7, 2012
Merged

Change "bigint" to "integer" in Postgres schema grammar. #33

merged 4 commits into from Dec 7, 2012

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Oct 25, 2012

Bigint has too big a range to be returned as an int in PHP. It is returned as a string, which can be confusing when expecting an int to be returned. In addition, the range of integer is suitable for most cases: -2147483648 to +2147483647.

Bigint has too big a range to be returned as an int in PHP. It is returned as a string, which can be confusing and lead to unexpected results. In addition, the range of integer is suitable for most cases: -2147483648 to +2147483647.
@franzliedke
Copy link
Contributor

@franzliedke franzliedke commented Oct 26, 2012

Looks like you need to update the unit tests. :)

@conradkleinespel
Copy link
Contributor Author

@conradkleinespel conradkleinespel commented Oct 26, 2012

Done. Thanks for the heads up :)

Edit: Seems like Travis is hanging. I just sent them an email to ask they look into the error.
Edit 2: Got the answer from Travis: have to update the pull request to get it to re-test everything.

@philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Dec 7, 2012

+1

taylorotwell added a commit that referenced this issue Dec 7, 2012
Change "bigint" to "integer" in Postgres schema grammar.
@taylorotwell taylorotwell merged commit 65fd848 into illuminate:master Dec 7, 2012
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants